-
-
Notifications
You must be signed in to change notification settings - Fork 10
Fix for enums. #32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for enums. #32
Conversation
Really appreciate it that you have also added some tests. I have reformat some of the code, and change the implemention to: if (targetType.IsEnum)
{
return Enum.ToObject(targetType, Convert.ToInt64(value));
} But it reveals another problem. When I was trying: if (targetType.IsEnum)
{
return Enum.ToObject(targetType, value);
} It failed because I believe this happens due to the deserialization from js |
@magiccodingman Maybe you should also check this as it was rejected in #25. I believe enums should work like this. |
How will I know when this becomes available in NuGet? I need this fix and the [MagicNotMapped] fix.
…________________________________
From: Magic ***@***.***>
Sent: Friday, February 14, 2025 11:50 AM
To: magiccodingman/Magic.IndexedDb ***@***.***>
Cc: bitzblitz ***@***.***>; Author ***@***.***>
Subject: Re: [magiccodingman/Magic.IndexedDb] Fix for enums. (PR #32)
Merged #32<#32> into master.
—
Reply to this email directly, view it on GitHub<#32 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABRD7ASLDK6D343YL3OSCHL2PYNE3AVCNFSM6AAAAABXDO3MQGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJWGMYTIOBQGE2TGNY>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
@bitzblitz I can just package a new one for you in the morning when I wake up and post it. |
However the |
Yes please.
From my phone.
…________________________________
From: yueyinqiu ***@***.***>
Sent: Friday, February 14, 2025 11:39:22 PM
To: magiccodingman/Magic.IndexedDb ***@***.***>
Cc: bitzblitz ***@***.***>; Mention ***@***.***>
Subject: Re: [magiccodingman/Magic.IndexedDb] Fix for enums. (PR #32)
However the MagicNotMapped fix has not been done yet. Maybe we could create a release<https://github.com/magiccodingman/Magic.IndexedDb/releases> when there is a new version published?
—
Reply to this email directly, view it on GitHub<#32 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABRD7AVYP4VYXQJMBHYB2JT2P3AHVAVCNFSM6AAAAABXDO3MQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQG4ZDGNBXHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
[yueyinqiu]yueyinqiu left a comment (magiccodingman/Magic.IndexedDb#32)<#32 (comment)>
However the MagicNotMapped fix has not been done yet. Maybe we could create a release<https://github.com/magiccodingman/Magic.IndexedDb/releases> when there is a new version published?
—
Reply to this email directly, view it on GitHub<#32 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABRD7AVYP4VYXQJMBHYB2JT2P3AHVAVCNFSM6AAAAABXDO3MQGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNRQG4ZDGNBXHE>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Write and read enum fields correctly.