Skip to content

feat(device): add ElectriQ EcoSilent12HPW config #3136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

XargsUK
Copy link

@XargsUK XargsUK commented Apr 10, 2025

This pull request includes updates to the DEVICES.md file and the addition of a new device configuration in the custom_components/tuya_local directory. The most important changes include adding a new device to the list and providing a configuration for it.

Documentation Updates:

Device Configuration:

  • Added configuration for ElectriQ EcoSilent12HPW in custom_components/tuya_local/devices/electriq_ecosilent12hpw_aircon.yaml, including entities for climate control, temperature settings, fan modes, and additional features like sleep mode and timer. Note the difference with this model to the EcoSilent12WAP is the additional heat pump.

@github-project-automation github-project-automation bot moved this to 👀 In review in Tuya Local Apr 10, 2025
make-all added a commit that referenced this pull request Apr 17, 2025
12HPW seems identical, except for the mode "smartcool" instead of "smart_cool".
"smartcool" is also used by EcoSilent 12WAP, so likely this was a typo in
the original config.

Update name to follow modern non-branded convention, and add a dummy products
section (commented out due to no product ids known)

Remove superfluous constraint with no conditions.

PR #3136
@make-all make-all closed this Apr 17, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Tuya Local Apr 17, 2025
@make-all
Copy link
Owner

Device is the same as already supported 14HPW

@XargsUK
Copy link
Author

XargsUK commented Apr 17, 2025

Device is the same as already supported 14HPW

@make-all I can take a look at a way to help present options to the user, as it's not intuitive to users that when they have a EcoSilent12HPW and there's no option for it, then they shouldn't be selecting EcoSilent12WAP but rather the EcoSilent14HPW; without the user having prerequisite knowledge of how the vendor structures their model numbers. It feels as though having brand selection, then model, and having a map in the codebase with references to generic profiles would be smoother UX than researching model numbers for products you don't own to determine similarities to your own and bruteforcing to determine if it will work.

I understand the DRY principle with this approach, but leaving out models from the model selection simply because there's a profile with the same config in the codebase but under a different model number seems problematic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants