Skip to content

Added "configured current" to goodcell_ev_charger.yaml #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

muhhh0
Copy link

@muhhh0 muhhh0 commented Apr 18, 2025

Added DP 125
For the Feyree charging cable, DP 125 is described as:
设置电流显示 → "Set Current Display" – it displays the configured current.

According to the Tuya API Explorer, the code for 125 is "set60a", but this does not make much sense (also, it is read-only).

This value is useful because you can lower the charging limit below 8 A, which is not officially supported. If you try to do so using "set charge current" (and set it to 6 A or 7 A), the value jumps back to 8 A.
Therefore, you can use "set charge current" to set the current and validate the actual setting via this new value.

@github-project-automation github-project-automation bot moved this to 👀 In review in Tuya Local Apr 18, 2025
make-all added a commit that referenced this pull request Apr 19, 2025
This is apparently the actual current used by the charger after clamping the
input within the limits (which depends on the charger model). It may be useful
to use, so made it available as an attribute.

Based on PR #3162
@make-all
Copy link
Owner

I think a sensor is overkill for this, an attribute makes it available for use by automations etc without adding extra noise to the UI.

@make-all make-all closed this Apr 19, 2025
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Tuya Local Apr 19, 2025
@dooblem
Copy link

dooblem commented May 1, 2025

Thanks for adding the attribute.

Having played with this device and tinytuya, I found that reading the value from DP 125 is always reliable. However the amps value is sometimes wrong when red from DP 115. @muhhh0 gave an example, but I think there are others, though I'm not 100% sure.

From my scripts I set the value using DP 115, but I read it using DP 125.

In HA it's certainly misleading for the user, because as described by @muhhh0 , when set to 6A, the value displayed is the old value, though the setting worked.

@make-all
Copy link
Owner

make-all commented May 3, 2025

Is it misleading though? Have you tested the device to see if it is actually limiting current to 6A when set to that? Or has it rejected that setting and continues charging at 8A, or the previous value?

@muhhh0
Copy link
Author

muhhh0 commented May 3, 2025

The device is actually limiting the current.
When you use the "Set charge current" slider to set a value below 8 A, the slider jumps back to the previous value, but the charger accepts the value. See screenshot - it contains "Configured Current" from my PR which displays DP 125 - slider is still at 10 A (setting before my change to 6A).
ev_charger
Don't know if there is a better way to display the actual setting.

@dooblem
Copy link

dooblem commented May 5, 2025

I think the best would be a single entity in HA : when changed it writes the value to DP 115, but gets the value from DP 125.
I don't know if it's easy though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants