Closed
Description
Describe the bug
https://github.com/makimenko/angular-template-for-threejs/blob/master/projects/atft/src/public_api.ts doesn't export all the directives and components.
Implications are
- you cannot use those directives in the app, e.g. if you want a
@ViewChild(WebGLRenderingComponent)
(as in my test code for Object Selection #36), and - in
app.component.html
you'll see lots of errors shown by Visual Studio Code:
Expected behavior
Export all directives and components in public_api.ts
. Now that we have a public package published, we should be cautious with modify the API without adhering to semver. If in doubt, make all properties/methods private first.
Suggested fix
For every subdirectory of projects/atft/lib
create an index.ts
exposing the public API. E.g. projects/atft/lib/cameras/index.ts
, then in public_api.ts
do export * from './lib/cameras
.