Skip to content

#373: Raycaster breaks inputs or forms bindings (due to preventDefault) #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2021

Conversation

makimenko
Copy link
Owner

No description provided.

@makimenko makimenko linked an issue May 3, 2021 that may be closed by this pull request
@makimenko makimenko enabled auto-merge May 3, 2021 17:16
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #384 (29c67c2) into master (f2c1800) will increase coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 29c67c2 differs from pull request most recent head 9368ba1. Consider uploading reports for the commit 9368ba1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #384      +/-   ##
==========================================
+ Coverage   23.93%   23.95%   +0.02%     
==========================================
  Files         109      109              
  Lines        2900     2897       -3     
  Branches      433      433              
==========================================
  Hits          694      694              
+ Misses       2156     2153       -3     
  Partials       50       50              
Impacted Files Coverage Δ
...ojects/atft/src/lib/raycaster/raycaster.service.ts 40.67% <ø> (+1.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f2c1800...9368ba1. Read the comment docs.

@makimenko makimenko merged commit 3afea69 into master May 3, 2021
@makimenko makimenko deleted the 373-raycaster-fix branch May 3, 2021 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Raycaster breaks inputs or forms bindings
1 participant