Cache signature metadata #1120
Merged
Cache signature metadata #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adriendelsalle
force-pushed
the
libsolv-signatures
branch
from
c6efd32 to
bcd067a
Compare
get package metadata from libsolv solvable get extra keys/values to patch serialized metadata test if deps are found in libsolv pool or not add a json_signable method to serialize signable package metadata update RepoIndexChecker and RepoChecker verify_package API update v0.6.0 PkgMgrRole accordingly improved transaction logs avoid parsing error when either extra_metadata or signatures is empty
adriendelsalle
force-pushed
the
libsolv-signatures
branch
from
88109aa to
6c6c9f6
Compare
add a role_error raise role error when verification of a role fails update tests
cursor bot
pushed a commit
to maresb/mamba
that referenced
this pull request
Nov 29, 2025
…entinel When creating a PackageInfo from a URL (explicit install), populate the defaulted_keys field to track which fields have stub/default values rather than real metadata. Per package type: - Conda: [_initialized, build_number, license, timestamp, track_features, depends, constrains] - Wheel/TarGz: above + [build, build_string] - Git: [_initialized, version, channel, subdir, fn, timestamp, build, build_string, build_number, license, track_features, depends, constrains] The _initialized sentinel enables fail-hard verification that all code paths properly initialize defaulted_keys. It can be removed in a future refactor if desired. The defaulted_keys infrastructure was introduced in PR mamba-org#1120 for signature verification but fell out of use in 2023 during the libsolv wrapper refactor. This commit revives its use for distinguishing "field has default value" from "field intentionally set to this value". Tests fixed (expected to pass after this commit): - defaulted_keys_populated_for_conda_url - defaulted_keys_populated_for_wheel_url - defaulted_keys_populated_for_tar_gz_url - defaulted_keys_populated_for_git_url NOTE: Tests need to be executed to verify GREEN status. This is part 1/2 of the fix for mamba-org#4095. Related: mamba-org#4095
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR requires
libsolvmodification: https://github.com/openSUSE/libsolv/pull/469/fileslibsolvsolvableextra_metadataorsignaturesis emptylibsolvpool or notjson_signablemethod to serialize signable package metadataextra_metadatato use for signature reproducibilityRepoIndexCheckerandRepoCheckerverify_packageAPIv0.6.0::PkgMgrRoleaccordinglyrole_errorwhen verification of a role fails (instead of athreshold_error)