add more channel_actions #230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btel
reviewed
Dec 10, 2020
wolfv
force-pushed
the
merge_actions
branch
2 times, most recently
from
7514b01 to
6407275
Compare
btel
reviewed
Dec 11, 2020
| logger.debug(f"adding file '{file.filename}' to channel '{channel_name}'") | ||
| file.file._file.seek(0, os.SEEK_END) | ||
| size = file.file._file.tell() | ||
| total_size += size |
Collaborator
There was a problem hiding this comment.
for the channel size limit: do we want to check whether all the files can be uploaded or we do that one by one and fail after N files have been already uploaded
Member
Author
There was a problem hiding this comment.
I like to fail early instead of halfway through.
Codecov Report
@@ Coverage Diff @@
## master #230 +/- ##
==========================================
+ Coverage 83.50% 83.71% +0.21%
==========================================
Files 31 31
Lines 2346 2414 +68
==========================================
+ Hits 1959 2021 +62
- Misses 387 393 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.