Format and lint codebase #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This automatically applies our linting rules that can be automatically applied.
This applies the formatting rules.
… not
This replaces `assert ${CONDITION} == True` to `assert ${CONDITION}`
and `assert ${CONDITION} == False` to `assert not ${CONDITION}`.
The ignored lint is too noisy.
While this is valid in python3.10 and greater, we are building on python3.8 in tests and can't put it in brackets as that forms a tuple.
jonbannister
approved these changes
Sep 5, 2024
morotti
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #107 by adding some strict formatting and lints, using
ruff.This PR touches many lines in the project and there may be a concern that this "clobbers" history. However, the history is always there, even if its not one step away. Further the advantages of having a consistently formatted and linted codebase are considerable going forward.