Don't use async compression stream #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were using `await` on the compression stream but this meant that somtimes the rest of the HTML document was being loaded before the resources had been inflated. Now, we decompress in a blocking manner by manually pumping the promise so that we eliminate all the async.
The HTML has changed as we've edited the jsinflate file
morotti
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were using
awaiton the compression stream but this meant that somtimes the rest of the HTML document was being loaded before the resources had been inflated.Now, we decompress in a blocking manner by manually pumping the promise so that we eliminate all the async.
This should fix #153