Skip to content

Fix fixture config #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 8, 2019
Merged

Conversation

stanislavlevin
Copy link
Contributor

Fix docs and tests due to pytest 3.7.1

pytest 3.7.1 changed behavior for fixture decorators. But later in 3.7.2 this was fixed by adding of __pytest_wrapped__ attribute, which is used to obtain the function up until the point a function was wrapped by pytest itself.

For related info please look at pytest-dev/pytest#3780

Removing of functionality is a surprise for most users/developers.
Meanwhile, fixture_config is used by setuptools for testing.

pytest 3.7.1 changed behavior for fixture decorators.
But later in 3.7.2 this was fixed by __pytest_wrapped__ attribute,
which is used to obtain the function up until the point a function
was wrapped by pytest itself.

Signed-off-by: Stanislav Levin <[email protected]>
@javefang javefang self-requested a review January 8, 2019 10:03
Copy link
Contributor

@javefang javefang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the contribution!

@javefang javefang merged commit c86bbcd into man-group:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants