ElementNumber: Add support to define element number for print_stats() #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pytest-profiling/pytest_profiling.py
Outdated
| @@ -27,9 +27,10 @@ class Profiling(object): | |||
| profs = [] | |||
| combined = None | |||
|
|
|||
| def __init__(self, svg, dir): | |||
| def __init__(self, svg, dir, element_number): | |||
There was a problem hiding this comment.
It may be good to make this a keyword argument with the current default to prevent a breaking change.
| @@ -98,11 +99,14 @@ def pytest_addoption(parser): | |||
| help="generate profiling graph (using gprof2dot and dot -Tsvg)") | |||
| group.addoption("--pstats-dir", nargs=1, | |||
| help="configure the dump directory of profile data files") | |||
| group.addoption("--element-number", action="store", default="20", | |||
| help="defines how many elements will display in a result") | |||
There was a problem hiding this comment.
Add type="int" here and set the default to 20 instead of the string. This would prevent you having to cast this to an int and potentially blowing up as the profiler is printing the summary.
mitzkia
force-pushed
the
element_number
branch
from
15af610 to
0103e2b
Compare
…tats() - It is possible that we need more stats than the default 20 Signed-off-by: Andras Mitzki <[email protected]>
mitzkia
force-pushed
the
element_number
branch
from
0103e2b to
055bf70
Compare
|
Updated |
|
LGTM, thanks for the contribution! |
|
was wondering why this feature wasn't working when I was trying it any chance we could get this published to pypi please? thanks for the work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andras Mitzki [email protected]