Skip to content

fix(typescript): fix query typings #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 13, 2019
Merged

fix(typescript): fix query typings #1

merged 3 commits into from
Jun 13, 2019

Conversation

manakuro
Copy link
Owner

@manakuro manakuro commented Jun 13, 2019

What:
Fix Query typings.

Why:
Typings error occurred because of incompatible with Query interface.

How:

  • Use NativeTestInstance type for returning Query interface.
  • Remove NativeTestInstance type from testRenderer argument in Query interface.
  • Fix ReactTestInstance.getProps type.

Checklist:

  • Documentation added to the
    docs site
  • Typescript definitions updated
  • Tests
  • Ready to be merged

Results:

$ yarn tsc                                                                                                                                                                          
yarn run v1.15.2
$ /Users/me/workspace/react-native/react-native-sample/node_modules/.bin/tsc
✨  Done in 30.35s.

@manakuro manakuro merged commit e33f28f into master Jun 13, 2019
@manakuro manakuro deleted the fix-query-typings branch June 13, 2019 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant