Feat/warn for dynamic dotnet#2568
Merged
williballenthin merged 19 commits intomandiant:masterfrom Feb 3, 2025
Merged
Conversation
williballenthin
requested changes
Jan 28, 2025
Collaborator
williballenthin
left a comment
williballenthin
left a comment
There was a problem hiding this comment.
I've added some comments inline. Would you review and let me know what you think @v1bh475u? If the proposals work for you, please try them out. If you disagree, let's figure out alternatives.
Signed-off-by: vibhatsu <maulikbarot2915@gmail.com>
Signed-off-by: vibhatsu <maulikbarot2915@gmail.com>
Signed-off-by: vibhatsu <maulikbarot2915@gmail.com>
Signed-off-by: vibhatsu <maulikbarot2915@gmail.com>
Contributor
Author
|
@williballenthin I have made the changes as we had discussed. Please review them whenever you are free. |
williballenthin
requested changes
Jan 28, 2025
Collaborator
williballenthin
left a comment
williballenthin
left a comment
There was a problem hiding this comment.
see inline suggestions.
…comments Signed-off-by: vibhatsu <maulikbarot2915@gmail.com>
Signed-off-by: vibhatsu <maulikbarot2915@gmail.com>
…e related functions Signed-off-by: vibhatsu <maulikbarot2915@gmail.com>
Contributor
Author
|
@williballenthin I have made some changes as you had suggested. Please review whenever you are free. |
Collaborator
williballenthin
left a comment
williballenthin
left a comment
There was a problem hiding this comment.
we're really close here! see inline comments.
Signed-off-by: vibhatsu <maulikbarot2915@gmail.com>
Signed-off-by: vibhatsu <maulikbarot2915@gmail.com>
Contributor
Author
|
Done with changes. Please review. |
williballenthin
approved these changes
Feb 3, 2025
Collaborator
williballenthin
left a comment
williballenthin
left a comment
There was a problem hiding this comment.
thanks @v1bh475u
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1864
Checklist