Skip to content

feat: added decoding functions calls#978

Merged
mr-tz merged 8 commits intomandiant:masterfrom
RahulSankhla312:rahul/decoding
Mar 24, 2024
Merged

feat: added decoding functions calls#978
mr-tz merged 8 commits intomandiant:masterfrom
RahulSankhla312:rahul/decoding

Conversation

@RahulSankhla312
Copy link
Contributor

This pull request addresses the issue titled "Show how many times a specific decoding function has been called" (#693).

Please review the changes I've implemented. I welcome any suggestions for necessary adjustments.

@RahulSankhla312
Copy link
Contributor Author

RahulSankhla312 commented Mar 19, 2024

@mr-tz Please review this pr , i have only kept the minimal changes.#978

@mr-tz
Copy link
Collaborator

mr-tz commented Mar 19, 2024

can you please fix the black fails?

@RahulSankhla312
Copy link
Contributor Author

@mr-tz I have fixed the black fails .

@mr-tz
Copy link
Collaborator

mr-tz commented Mar 20, 2024

mypy outstanding:

floss/main.py:769: error: Dict entry 0 has incompatible type "str": "Any"; expected "int": "float"  [dict-item]
floss/main.py:769: error: Dict entry 1 has incompatible type "str": "Any"; expected "int": "float"  [dict-item]
Found 2 errors in 1 file (checked 56 source files)

@RahulSankhla312
Copy link
Contributor Author

@mr-tz i think i corrected the mypy errors.

@mr-tz
Copy link
Collaborator

mr-tz commented Mar 21, 2024

great, now only need to update the tests at

# floss --no static -j tests/data/src/decode-in-place/bin/test-decode-in-place.exe

@RahulSankhla312
Copy link
Contributor Author

@mr-tz i have added some test cases for test_load.py

Copy link
Collaborator

@mr-tz mr-tz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you very much! nice work!

@mr-tz mr-tz merged commit 5c2d84e into mandiant:master Mar 24, 2024
This was referenced Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants