[Snyk] Security upgrade express from 4.17.1 to 4.22.0#163
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-QS-15268416
There was a problem hiding this comment.
Pull request overview
Updates the docs workspace dependency on express to address a Snyk-reported vulnerability in the Yarn dependency tree.
Changes:
- Bump
expressindocs/package.jsonfrom^4.17.1to^4.22.0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "doctrine": "^3.0.0", | ||
| "emotion-theming": "^10.0.27", | ||
| "express": "^4.17.1", | ||
| "express": "^4.22.0", |
There was a problem hiding this comment.
express was bumped in docs/package.json, but the workspace lockfile still resolves express to 4.17.1 (and qs 6.7.0). Please regenerate and commit the updated root yarn.lock so installs/CI actually pick up express@^4.22.0 and the vulnerability fix takes effect.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94834a4ab2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "doctrine": "^3.0.0", | ||
| "emotion-theming": "^10.0.27", | ||
| "express": "^4.17.1", | ||
| "express": "^4.22.0", |
There was a problem hiding this comment.
Commit lockfile update for express bump
This dependency bump is incomplete because docs/package.json now requires express ^4.22.0, but the committed lockfile still resolves express@^4.17.1 to 4.17.1 (yarn.lock:7425). That leaves the checked-in dependency graph on the vulnerable version, so lockfile-based auditing/reproducibility workflows will not reflect the intended security fix until yarn.lock is regenerated and committed alongside this change.
Useful? React with 👍 / 👎.
Snyk has created this PR to fix 1 vulnerabilities in the yarn dependencies of this project.
Snyk changed the following file(s):
docs/package.jsonNote for zero-installs users
If you are using the Yarn feature zero-installs that was introduced in Yarn V2, note that this PR does not update the
.yarn/cache/directory meaning this code cannot be pulled and immediately developed on as one would expect for a zero-install project - you will need to runyarnto update the contents of the./yarn/cachedirectory.If you are not using zero-install you can ignore this as your flow should likely be unchanged.
Vulnerabilities that will be fixed with an upgrade:
SNYK-JS-QS-15268416
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Allocation of Resources Without Limits or Throttling