Updates ingress definition with ingressClassName field#51
Open
iceowlbeer wants to merge 8 commits intomanics:mainfrom
Open
Updates ingress definition with ingressClassName field#51iceowlbeer wants to merge 8 commits intomanics:mainfrom
iceowlbeer wants to merge 8 commits intomanics:mainfrom
Conversation
manics
reviewed
Jul 2, 2025
Owner
manics
left a comment
manics
left a comment
There was a problem hiding this comment.
Sorry for missing this.
Can you also bump the chart version
to
0.4.12? This will trigger an automated release of the chart after this is merged.
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
Co-authored-by: Simon Li <orpheus+devel@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility of stating a name of a IngressClass in a field "ingressClassName".
Why?
I am getting the following warning when I deploy the ingresses with the annotation instead of the dedicated field from the spec
W1129 12:41:17.534196 143471 warnings.go:70] annotation "kubernetes.io/ingress.class" is deprecated, please use 'spec.ingressClassName' instead
See also https://kubernetes.io/docs/concepts/services-networking/ingress/#deprecated-annotation