Removed cz fixing for comoving distances #275
Merged
+11
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
@misharash Thanks for that. Do you mind adding an entry to the Changelog - something to the effect of "Only perform z vs cz check if co-moving distance is not set" @lgarrison Good to merge? |
Contributor
Author
|
Sure, added a line to the changelog under 2.5.0 fixes. |
Collaborator
|
I'm traveling right now but will check this on Friday!
…On Thu, May 12, 2022, 12:45 AM misharash ***@***.***> wrote:
Sure, added a line to the changelog under 2.5.0 fixes.
—
Reply to this email directly, view it on GitHub
<#275 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABLA7S2L3LB7PRPLBVQJ3I3VJSEFXANCNFSM5VTQOPHQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
lgarrison
approved these changes
May 13, 2022
Collaborator
lgarrison
left a comment
lgarrison
left a comment
There was a problem hiding this comment.
Looks straightforward, thanks for the fix!
manodeep
approved these changes
May 18, 2022
Owner
|
Thanks for the fix @misharash |
manodeep
approved these changes
May 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
is_comoving_distis set, cz is actually comoving distance, therefore fixing the inputs by speed of light doesn't make sense, as simplest resolution of this problem I don't setfix_czthen. Fixes #274.