[@mantine/core] Stepper: fix separator color #7795
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello 👋 I noticed that the Stepper separator had a different color between horizontal and vertical orientations. For instance you can see this on the docs website:
mantine-color-gray-1
mantine-color-gray-2
While looking at the code I saw some dead code so I figured I would open a PR with a small cleanup. Here's a summary of what I did:
getStyles('separator')
is only every applied whenorientation === 'horizontal'
so the whole rule for.separator &:where([data-orientation='vertical'])
can be deleted.--stepper-outline-color
variable to make sure both orientations use the same color for the separator.--stepper-outline-thickness
variable for ease of customizationHere is a before and after