Update to last version of angular 16 + add tests #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug introducted in last versions, when changing call from request to specific call method. But body must be given in an other parameters.
This commit removes the unnecessary constructor and updates the dependencies in ApiService. It also corrects the useMock variable initialization in ngx-http-annotations.utils.ts to improve reliability. Additionally, it adds "@hirez_io/observer-spy" in package.json for easier testing. Also, removes 'extends HttpRestService' from the SomeRestService example for simplicity.Update ApiService dependencies and remove unnecessary constructor In this commit, the unnecessary constructor in ApiService is removed, and the dependencies are updated to improve code reliability. The useMock variable initialization in ngx-http-annotations.utils.ts is also corrected. The dependency "@hirez_io/observer-spy" is added to package.json for more efficient testing. Additionally, the 'extends HttpRestService' is removed from the SomeRestService example for simplicity.
The project was updated to the latest version of Angular and the Nx library. This includes updating Angular from v14.2.0 to v16.1.3 and Nx from v14.8.5 to v16.4.1. This also necessitated changes to settings and configuration files to be in compliance with the new versions. Some of these updates include specifying the target script version and turning off usage of the 'Define' keyword for class fields. These updates not only ensure that our codebase stays current with the latest Angular and Nx features but it also helps to circumvent issues that may occur in older versions.
The project was updated to the latest version of Angular and the Nx library. This includes updating Angular from v14.2.0 to v16.1.3 and Nx from v14.8.5 to v16.4.1. This also necessitated changes to settings and configuration files to be in compliance with the new versions. Some of these updates include specifying the target script version and turning off usage of the 'Define' keyword for class fields. These updates not only ensure that our codebase stays current with the latest Angular and Nx features but it also helps to circumvent issues that may occur in older versions.
…' into wip-update-ngx # Conflicts: # .browserslistrc # angular.json # apps/sample-ngx-http-annotations/src/.browserslistrc # apps/sample-ngx-http-annotations/src/polyfills.ts # package-lock.json # package.json # projects/ngx-http-annotations/package.json # projects/ngx-http-annotations/src/test.ts # projects/ngx-http-annotations/tsconfig.lib.prod.json # src/environments/environment.ts # src/test.ts # test-api/src/environments/environment.ts # test-api/src/polyfills.ts # test-api/src/test.ts # tsconfig.json # tslint.json # yarn.lock
-> Updates to Angular 16, and compile libs to ivy -> change to nx workspace -> Add unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it works for angular 16, with compile with Ivy.
Use nx of this.
Add unit test for this.