Skip to content

Conversation

@LeeroyDing
Copy link
Contributor

Lacks exception handling so far.

@manukall
Copy link
Owner

hey, thanks for the PR. happy as always :-)

i think we should think about error handling here, though, and not take the easy route. not sure what a good solution would be yet. maybe just making the email part modular and allow users to provide their own implementation. i imagine not everyone might want to use mailgun anyway.

@LeeroyDing
Copy link
Contributor Author

Let's save the mailgun thing for later, I believe it will serve most people well.

Sending emails asynchronously would require a different approach of error handling, since you won't know the result at the point you want to send the mail. Do you have any good idea? :)

@manukall
Copy link
Owner

manukall commented Aug 3, 2015

i think there's no best way to error handling here. that's why i think we should let users provide their own implementation. some might want to forward the error to something like rollbar, some might want to retry a few times, some might want something completely different.

@LeeroyDing
Copy link
Contributor Author

Letting users implement their own mailer sounds good. The problem would be the docs tho.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants