Add Type: Module to Package.Json

[ingalls]

👋 Hey @mapsam,

Thanks a ton for the TS migration, it's wonderful to replace my shims! The current version (2.0.0) is causing some issues with my deploy tooling as the TS package uses Module exports syntax without declaring itself a module.

I've added the type: module in the package.json required to allow use of exports instead of module.exports

[mapsam]

Woops thanks for the ping @ingalls, sorry about the error there! I'm no longer able to merge these PRs, but maybe @greenlaw or @AlexanderBelokon can take a look.

[ingalls]

I saw that after I cut this PR!! Congrats on the new gig!

[greenlaw]

@ingalls I think this will break CJS imports if merged, is that your understanding?

We just went through this on another repo and ended up using a dual-packaging approach. Can you take a look here and see if the same approach would work for you here? mapbox/sphericalmercator#47

[ingalls]

@greenlaw Yes, you are correct, my head is 100% into ESM so I haven't dealt with compat with CJS in a bit but your approach in SM seems like the way to go to retain CJS support.

I'd be happy to cut a PR following your approach with SM tomorrow if that would be useful.

[mapsam]

Thanks y'all! 🙌

[greenlaw]

@ingalls That would be great - thanks

[ingalls]

@greenlaw I've updated the PR with the same dual ESM/CJS approach you took in the SM library. Let me know if this looks good to you! Thanks all!

[greenlaw]

@ingalls Looks good, just two minor things:

• I think we can keep the prepublishOnly script
• Could you bump the version to 2.0.1 and npm i to update package-lock.json again?

Happy to approve/merge once that's done.

[ingalls]

@greenlaw done.

[greenlaw]

Thanks @ingalls !

[greenlaw]

v2.0.1 has been published 👍