fix: avoid synchronous calls where possible#1320
Merged
acalcutt merged 1 commit intomaptiler:masterfrom Jul 31, 2024
Merged
Conversation
akx
force-pushed
the
avoid-sync
branch
3 times, most recently
from
02341fb to
cf49198
Compare
Collaborator
|
I would love another review of this, if anyone has the time. In general I think this is a good direction, but I am not very familiar with promises. I assume this makes things run a bit more in parallel so it would increase response times? I reached out to @mnutt to see if he can offer a review, but I'm not sure if he is around right now and/or if he needs his permissions to this repo put back like I had to get done. |
Contributor
Author
It should decrease response times (that is, make things faster) where there are multiple concurrent requests to code paths which previously used |
Signed-off-by: Aarni Koskela <akx@iki.fi>
acalcutt
approved these changes
Jul 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were a bunch of
*Synccalls that were rather easy to convert to promisified ones, either viautil.promisifyor justnode:fs/promises.There's at least one more place I didn't touch, solely because it would have required refactoring all of
server.js::startto be async.There are other places left (out of scope of this PR) where e.g. callback async could be converted to promises, etc.