Skip to content

Relax Node.js compatibility for -light version#410

Merged
petrsloup merged 1 commit intomaptiler:masterfrom
jdesboeufs:relax-light-version-compatibility
Jan 17, 2020
Merged

Relax Node.js compatibility for -light version#410
petrsloup merged 1 commit intomaptiler:masterfrom
jdesboeufs:relax-light-version-compatibility

Conversation

@jdesboeufs
Copy link
Copy Markdown
Contributor

Hello!

tileserver-gl-light works perfectly with Node.js 12 and 13.
This PR relax the field engines.node in its package.json file.

We actually use a tileserver-gl-light fork in French governement digital services, with this improvement :)

Jerome

@klokan
Copy link
Copy Markdown
Member

klokan commented Jan 17, 2020

Thanks @jdesboeufs for the contribution !

@petrsloup - could you please review / merge?

@klokan klokan requested a review from petrsloup January 17, 2020 12:30
@klokan klokan added this to the v3.0 milestone Jan 17, 2020
@petrsloup petrsloup merged commit caa641c into maptiler:master Jan 17, 2020
@petrsloup
Copy link
Copy Markdown
Member

Yes, you are right -- the -light version does not have any native dependencies, so the version restriction is unnecessarily strict here. Thanks for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants