Open mbtiles in readonly mode#506
Merged
acalcutt merged 1 commit intomaptiler:masterfrom Sep 24, 2022
Merged
Conversation
Collaborator
|
I think this one is worth adding. I used this in my fork and didn't have any issue with it. Are there any instances where tileserver would write back to the mbtiles file? I don't think I have seen any. |
acalcutt
approved these changes
Sep 24, 2022
Collaborator
acalcutt
left a comment
acalcutt
left a comment
There was a problem hiding this comment.
I think this is a good idea
Contributor
Author
|
thanks, nice to see that tileserver-gl development is picking back up again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open mbtiles in readonly mode as tileserver-gl never writes to them.
I'm not sure if there are any real benefits to this, but I figured it can't hurt.