Fix HUP kill not reloading config#630
Merged
acalcutt merged 9 commits intomaptiler:masterfrom Oct 28, 2022
Merged
Conversation
Contributor
|
I have tested this PR under Docker and it fixes #629: reloading of an updated config file works in both ways:
|
mnutt
approved these changes
Oct 28, 2022
Contributor
mnutt
left a comment
There was a problem hiding this comment.
I suspect that clearing the require cache might have been to give the ability to reload options.dataDecorator which is loaded via require(). IMO that seems like it's approaching ad-hoc hot-reloading territory and I think it's fine to not support.
Contributor
|
Please consider resolving #629 |
Collaborator
Author
|
I'm planning to resolve it after the docker is updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix for #629, which was broken in the syntax change of #606
After looking at the code changes, it seems like the sections of code that handles SIGINT/SIGHUP and restarting was not being used anymore. This change renames the functions a bit so the SIGINT/SIGHUP code is actually used.