Fix 'use omit=dev' warning. copy package-lock.json if it exists#632
Merged
acalcutt merged 3 commits intomaptiler:masterfrom Oct 28, 2022
Merged
Fix 'use omit=dev' warning. copy package-lock.json if it exists#632acalcutt merged 3 commits intomaptiler:masterfrom
acalcutt merged 3 commits intomaptiler:masterfrom
Conversation
mnutt
approved these changes
Oct 28, 2022
Contributor
mnutt
left a comment
mnutt
left a comment
There was a problem hiding this comment.
This looks good, I think instead of npm install we could also try using npm ci which ensures that it uses only the exact version specified in the package-lock.json?
light version won't copy over package-lock, so keep that npm install.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes "--production" to "--omit=dev" to avoid docker build warning.
Adds a package-lock.json to the project.. Copy package-lock.json to docker it exists.