Skip to content

Add Docker Healthcheck #636

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
acalcutt merged 7 commits into from
Nov 7, 2022
Merged

Add Docker Healthcheck #636

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
24e26be
Add Docker Healthcheck
zstadler Nov 3, 2022
8c96604
Merge branch 'master' into healthcheck
zstadler Nov 3, 2022
cdd72cd
Update Dockerfile_light
zstadler Nov 3, 2022
b4aac41
Merge branch 'master' into pr/636
acalcutt Nov 7, 2022
a82536d
Merge branch 'master' into pr/636
acalcutt Nov 7, 2022
400d9e6
Update healthcheck.js
acalcutt Nov 7, 2022
945c6fa
update version
acalcutt Nov 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,3 +81,5 @@ EXPOSE 80
USER node:node

ENTRYPOINT ["/usr/src/app/docker-entrypoint.sh"]

HEALTHCHECK CMD node /usr/src/app/src/healthcheck.js
1 change: 1 addition & 0 deletions Dockerfile_light
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,3 +32,4 @@ COPY / /usr/src/app
RUN cd /usr/src/app && npm install --omit=dev
RUN ["chmod", "+x", "/usr/src/app/docker-entrypoint.sh"]
USER node:node
HEALTHCHECK CMD node /usr/src/app/src/healthcheck.js
18 changes: 18 additions & 0 deletions src/healthcheck.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import * as http from 'http';
var options = {
timeout: 2000,
};
var url = "http://localhost:80/health";
var request = http.request(url, options, (res) => {
console.log(`STATUS: ${res.statusCode}`);
if (res.statusCode == 200) {
Copy link
Copy Markdown
Contributor

@vinayakkulkarni vinayakkulkarni Nov 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (res.statusCode == 200) {
if (res.statusCode === 200) {

Copy link
Copy Markdown
Contributor Author

@zstadler zstadler Nov 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type of the response StatusCode is a number. IMO, === is not needed for comparing that number with 200.

process.exit(0);
} else {
process.exit(1);
}
});
request.on("error", function (err) {
console.log("ERROR");
process.exit(1);
});
request.end();