fix: issue with husky install#639
Merged
acalcutt merged 2 commits intomaptiler:masterfrom Nov 9, 2022
Merged
Conversation
Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
1 task
Collaborator
|
Hmm, this worked for the full version build, but the light version failed. maybe the setting of NODE_ENV="production" isn't working in Dockerfile_light? |
Contributor
Author
Will test for light version in some time, just reached home from work ;) |
Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
acalcutt
approved these changes
Nov 9, 2022
Collaborator
acalcutt
left a comment
There was a problem hiding this comment.
this fixes both docked builds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Yep, I too came across this issue in setting up tileserver-gl internally! Sorry about that.
Signed-off-by: Vinayak Kulkarni 19776877+vinayakkulkarni@users.noreply.github.com