Skip to content

fix: issue with husky install#639

Merged
acalcutt merged 2 commits intomaptiler:masterfrom
vinayakkulkarni:fix/husky-setup-in-prod
Nov 9, 2022
Merged

fix: issue with husky install#639
acalcutt merged 2 commits intomaptiler:masterfrom
vinayakkulkarni:fix/husky-setup-in-prod

Conversation

@vinayakkulkarni
Copy link
Copy Markdown
Contributor

Yep, I too came across this issue in setting up tileserver-gl internally! Sorry about that.

Signed-off-by: Vinayak Kulkarni 19776877+vinayakkulkarni@users.noreply.github.com

Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
@acalcutt
Copy link
Copy Markdown
Collaborator

acalcutt commented Nov 9, 2022

Hmm, this worked for the full version build, but the light version failed. maybe the setting of NODE_ENV="production" isn't working in Dockerfile_light?

Error: Process completed with exit code 1.
npm ERR!     /home/runner/.npm/_logs/2022-[11](https://github.com/acalcutt/tileserver-gl/actions/runs/3429274451/jobs/5714672122#step:19:12)-09T[15](https://github.com/acalcutt/tileserver-gl/actions/runs/3429274451/jobs/5714672122#step:19:16)_50_25_[20](https://github.com/acalcutt/tileserver-gl/actions/runs/3429274451/jobs/5714672122#step:19:21)6Z-debug-0.log
npm ERR! A complete log of this run can be found in:

npm ERR! command sh -c -- node -e "if (process.env.NODE_ENV !== 'production'){ process.exit(1) } " || husky install
npm ERR! command failed
npm ERR! path /home/runner/work/tileserver-gl/tileserver-gl/light
npm ERR! code 1
husky - .git can't be found (see https://typicode.github.io/husky/#/?id=custom-directory)

> node -e "if (process.env.NODE_ENV !== 'production'){ process.exit(1) } " || husky install

@vinayakkulkarni
Copy link
Copy Markdown
Contributor Author

Hmm, this worked for the full version build, but the light version failed. maybe the setting of NODE_ENV="production" isn't working in Dockerfile_light?

Error: Process completed with exit code 1.
npm ERR!     /home/runner/.npm/_logs/2022-[11](https://github.com/acalcutt/tileserver-gl/actions/runs/3429274451/jobs/5714672122#step:19:12)-09T[15](https://github.com/acalcutt/tileserver-gl/actions/runs/3429274451/jobs/5714672122#step:19:16)_50_25_[20](https://github.com/acalcutt/tileserver-gl/actions/runs/3429274451/jobs/5714672122#step:19:21)6Z-debug-0.log
npm ERR! A complete log of this run can be found in:

npm ERR! command sh -c -- node -e "if (process.env.NODE_ENV !== 'production'){ process.exit(1) } " || husky install
npm ERR! command failed
npm ERR! path /home/runner/work/tileserver-gl/tileserver-gl/light
npm ERR! code 1
husky - .git can't be found (see https://typicode.github.io/husky/#/?id=custom-directory)

> node -e "if (process.env.NODE_ENV !== 'production'){ process.exit(1) } " || husky install

Will test for light version in some time, just reached home from work ;)

Signed-off-by: Vinayak Kulkarni <19776877+vinayakkulkarni@users.noreply.github.com>
Copy link
Copy Markdown
Collaborator

@acalcutt acalcutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this fixes both docked builds

@acalcutt acalcutt merged commit 0346d5c into maptiler:master Nov 9, 2022
@vinayakkulkarni vinayakkulkarni deleted the fix/husky-setup-in-prod branch November 10, 2022 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants