Skip to content
This repository was archived by the owner on Aug 19, 2021. It is now read-only.

[ISSUE-7] Add rules and messages as dependencies #8

Merged
merged 1 commit into from
Jan 21, 2020
Merged

[ISSUE-7] Add rules and messages as dependencies #8

merged 1 commit into from
Jan 21, 2020

Conversation

davityavryan
Copy link
Contributor

Closes #7

@marceloadsj
Copy link
Owner

marceloadsj commented Jan 21, 2020

I know using a non deterministic way to inject the params on dependency array of react hooks is a bad practice, like both ways:

The way it was:

useEffect(() => {

}, Object.values);

Or the new way:

useEffect(() => {

}, [...Object.values, a, b, c]);

But, to avoid breaking changes, I think this will be the best approach for now.
I'm merging this one into master, and we can plan a new small release.

@marceloadsj marceloadsj merged commit da2f822 into marceloadsj:master Jan 21, 2020
@davityavryan
Copy link
Contributor Author

Hey @marceloadsj ,
Can I have a release for this one please?
I should fix the bug in our system today ;(

@marceloadsj
Copy link
Owner

Hey man, yes yes! Sorry my delay. Let me do this here quickly! :)

@marceloadsj
Copy link
Owner

Done mate, again sorry my delay!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Messages are not updated
2 participants