Skip to content

MCOL 5675 - fix error message for null-safe equal #3754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 4 commits into
base: stable-23.10
Choose a base branch
from
Draft

MCOL 5675 - fix error message for null-safe equal #3754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cde0970
add test
mariadb-KristinaPavlova Aug 27, 2025
0d27c40
fix: add check for null-safe-equal
mariadb-KristinaPavlova Sep 9, 2025
831c515
Merge branch 'stable-23.10' into MCOL-5675
mariadb-KristinaPavlova Sep 9, 2025
e9f6046
update test
mariadb-KristinaPavlova Sep 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions dbcon/mysql/ha_mcs_execplan.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1656,6 +1656,12 @@ bool buildPredicateItem(Item_func* ifp, gp_walk_info* gwip)
{
// Convert "a <=> b" to (a = b OR (a IS NULL AND b IS NULL))"
idbassert(gwip->rcWorkStack.size() >= 2);
if(std::strcmp(ifp->func_name(), "<=>") == 0)
{
gwip->fatalParseError= true;
gwip->parseErrorText = "<=> (null-safe equal) is not supported in Columnstore";
return false;
}
ReturnedColumn* rhs = gwip->rcWorkStack.top();
gwip->rcWorkStack.pop();
ReturnedColumn* lhs = gwip->rcWorkStack.top();
Expand Down
17 changes: 17 additions & 0 deletions mysql-test/columnstore/basic/r/mcol-5675.result
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
DROP DATABASE IF EXISTS test_mcol5675;
CREATE DATABASE test_mcol5675;
USE test_mcol5675;
CREATE TABLE person (name varchar(100) NOT NULL, surname varchar(100) DEFAULT NULL )
ENGINE=Columnstore DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_general_ci ;
insert into person (name, surname) values ('Warren', NULL), ('Charlie', 'Peterson');
SELECT * FROM person WHERE surname <=> 1;
ERROR HY000: Internal error: <=> (null-safe equal) is not supported in Columnstore
DROP TABLE person;
CREATE TABLE person (name varchar(100) NOT NULL, surname varchar(100) DEFAULT NULL )
ENGINE=InnoDB DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_general_ci ;
insert into person (name, surname) values ('Warren', NULL), ('Charlie', 'Peterson');
SELECT * FROM person WHERE surname <=> 1;
name surname
Warnings:
Warning 1292 Truncated incorrect DECIMAL value: 'Peterson'
DROP DATABASE test_mcol5675;
26 changes: 26 additions & 0 deletions mysql-test/columnstore/basic/t/mcol-5675.test
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
--disable_warnings
DROP DATABASE IF EXISTS test_mcol5675;
--enable_warnings

CREATE DATABASE test_mcol5675;
USE test_mcol5675;

CREATE TABLE person (name varchar(100) NOT NULL, surname varchar(100) DEFAULT NULL )
ENGINE=Columnstore DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_general_ci ;

insert into person (name, surname) values ('Warren', NULL), ('Charlie', 'Peterson');

--error 1815
SELECT * FROM person WHERE surname <=> 1;

DROP TABLE person;

CREATE TABLE person (name varchar(100) NOT NULL, surname varchar(100) DEFAULT NULL )
ENGINE=InnoDB DEFAULT CHARSET=utf8mb3 COLLATE=utf8mb3_general_ci ;

insert into person (name, surname) values ('Warren', NULL), ('Charlie', 'Peterson');

SELECT * FROM person WHERE surname <=> 1;

#clear
DROP DATABASE test_mcol5675;