GameList: Use rc_client API for fetching game titles in icon download#1
Closed
mariobob wants to merge 1 commit intodownload-game-iconsfrom
Closed
GameList: Use rc_client API for fetching game titles in icon download#1mariobob wants to merge 1 commit intodownload-game-iconsfrom
mariobob wants to merge 1 commit intodownload-game-iconsfrom
Conversation
This was referenced Dec 4, 2025
Owner
Author
|
Opened pull request in https://github.com/stenzek/duckstation (3658) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated
DownloadGameIcons()to use the newrc_client_begin_fetch_game_titles()API method instead of callingrc_apidirectly.Changes
FetchGameTitlesParametersstruct andFetchGameTitlesCallbackfor the async operationrc_api_fetch_game_titlesusage withrc_client_begin_fetch_game_titlesMotivation
Per review feedback on the original PR (stenzek#3655 (comment)), we want to avoid direct usage of the
rc_api, in favor of the higher-levelrc_clientinterface.Depends on: RetroAchievements/rcheevos#484