Skip to content

Minor improvements in the providers map in examples#500

Merged
techknowlogick merged 4 commits into
markbates:masterfrom
antichris:minor-example-providers-map-improvements
Feb 27, 2023
Merged

Minor improvements in the providers map in examples#500
techknowlogick merged 4 commits into
markbates:masterfrom
antichris:minor-example-providers-map-improvements

Conversation

@antichris
Copy link
Copy Markdown
Contributor

  1. Initialize provider title map instead adding values one by one.

    It's much more readable this way.

    And, technically, more resource efficient (on my system, ~-59% sec/op, ~-51% B/op, -2/3 allocs/op). Although — who cares — this only runs once and in an example.

  2. Spell Battle.net the way they do.

  3. Spell LinkedIn the way they do and prefer done.

It's much more readable this way.
And, technically, more resource efficient (on my system, ~-59% sec/op,
~-51% B/op, -2/3 allocs/op). Although — who cares — this only runs once
and in an example.
@techknowlogick
Copy link
Copy Markdown
Collaborator

techknowlogick commented Feb 27, 2023

Thanks so much for this PR 😃 I'm going to remove the hidden file, but will merge this PR shortly.

edit: nvm, I saw what the hidden file did, and will merge this as-is :)

@techknowlogick techknowlogick merged commit 271cf13 into markbates:master Feb 27, 2023
@antichris antichris deleted the minor-example-providers-map-improvements branch February 27, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants