Minor improvements in the providers map in examples #500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's much more readable this way. And, technically, more resource efficient (on my system, ~-59% sec/op, ~-51% B/op, -2/3 allocs/op). Although — who cares — this only runs once and in an example.
042f531 is a syntactic change not a semantic one.
Collaborator
|
Thanks so much for this PR 😃 edit: nvm, I saw what the hidden file did, and will merge this as-is :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize provider title map instead adding values one by one.
It's much more readable this way.
And, technically, more resource efficient (on my system, ~-59% sec/op, ~-51% B/op, -2/3 allocs/op). Although — who cares — this only runs once and in an example.
Spell Battle.net the way they do.
Spell LinkedIn the way they do and prefer done.