Skip to content

Conversation

@ccaneke
Copy link
Contributor

@ccaneke ccaneke commented Oct 1, 2023

Information on reddit oauth2 can be found here.

@ccaneke
Copy link
Contributor Author

ccaneke commented Oct 1, 2023

The unit test for the provider github.com/markbates/goth/providers/vk is failing. It looks like a simple fix. Can I fix it myself or would you prefer the author fixes it?

Edit: My apologies, it was the unit test for wechat that was failing.

@techknowlogick
Copy link
Collaborator

@ccaneke If you are able to fix it that would be appreciated. Thanks 🙏 Feel free to do it in this PR or another

@ccaneke
Copy link
Contributor Author

ccaneke commented Oct 2, 2023

@ccaneke If you are able to fix it that would be appreciated. Thanks 🙏 Feel free to do it in this PR or another

I fixed the failing wechat test. All tests should now pass. For some reason, the assertion a.Equal mixed up the expected and actual results. So I swapped them.

@ccaneke
Copy link
Contributor Author

ccaneke commented Oct 2, 2023

@techknowlogick please can you take a look at the latest error. It says:

Error: providers/reddit/reddit.go:108:15: undefined: io.ReadAll

I'm not sure why this is happening.

@techknowlogick
Copy link
Collaborator

I'm not sure why this is happening.

It's likely due to go1.15 not having the functions in io, but still having them in io/ioutil. A deprecation may be needed of go 1.15, but testing this locally it works so I'll merge it.

Thanks again for the PR, plus also a thanks for fixing the unrelated tests :)

@techknowlogick techknowlogick merged commit ef6c303 into markbates:master Oct 3, 2023
@ccaneke
Copy link
Contributor Author

ccaneke commented Oct 3, 2023

I'm not sure why this is happening.

It's likely due to go1.15 not having the functions in io, but still having them in io/ioutil. A deprecation may be needed of go 1.15, but testing this locally it works so I'll merge it.

Thanks again for the PR, plus also a thanks for fixing the unrelated tests :)

Thanks for explaining, that makes perfect sense, ioutils functions recently got moved to io.

My pleasure, I hope to contribute more in anyway I can.

@celarye
Copy link
Contributor

celarye commented Jun 20, 2024

It seems like the README got never updated to include Reddit in the Providers list? Or is it not functional at this moment?

@celarye
Copy link
Contributor

celarye commented Jul 9, 2024

@techknowlogick can you elaborate?

@techknowlogick
Copy link
Collaborator

@celarye it just hasn't made it's may into the readme, if you'd like to make a PR to add it in, that would be very appreciated. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants