-
Notifications
You must be signed in to change notification settings - Fork 629
Add reddit provider and session #523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The unit test for the provider Edit: My apologies, it was the unit test for wechat that was failing. |
|
@ccaneke If you are able to fix it that would be appreciated. Thanks 🙏 Feel free to do it in this PR or another |
I fixed the failing wechat test. All tests should now pass. For some reason, the assertion |
|
@techknowlogick please can you take a look at the latest error. It says: I'm not sure why this is happening. |
It's likely due to go1.15 not having the functions in io, but still having them in io/ioutil. A deprecation may be needed of go 1.15, but testing this locally it works so I'll merge it. Thanks again for the PR, plus also a thanks for fixing the unrelated tests :) |
Thanks for explaining, that makes perfect sense, ioutils functions recently got moved to io. My pleasure, I hope to contribute more in anyway I can. |
|
It seems like the README got never updated to include Reddit in the Providers list? Or is it not functional at this moment? |
|
@techknowlogick can you elaborate? |
|
@celarye it just hasn't made it's may into the readme, if you'd like to make a PR to add it in, that would be very appreciated. Thanks! |
Information on reddit oauth2 can be found here.