Remove Deprecated io/ioutil #600
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
ccoVeille
suggested changes
Mar 14, 2025
gothic/gothic.go
Outdated
| "fmt" | ||
| "io" | ||
| "io/ioutil" | ||
|
|
There was a problem hiding this comment.
Please fix imports with goimports or gci
This comment states for all files
There was a problem hiding this comment.
If the PR is about ioutil deprecation
I don't get why you are updating go.modand go.sum
Contributor
Author
There was a problem hiding this comment.
That's my fault. Automatic go mod tidy && go mod vendor
Collaborator
|
Thanks! Could you resolve the conflicts and the other feedback and I'll be able to merge this. Thanks for the other PR too |
Collaborator
|
Oh lol, nvm. I guess I merged both in the same go with the other one. Thanks again! |
Contributor
Author
|
Closing as no longer relevant. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is 1 of the 2 primary components of
#570
I decided to split that PR up in order to potentially make merging the changes less "big bang" and more "incremental".