fix: allow escaped newline in link text #3752
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @UziTech, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a bug where escaped newlines within Markdown link text were not correctly parsed. The changes involve refining the regular expressions responsible for parsing various Markdown elements to properly handle \ followed by any character, including newlines. This ensures that link text containing escaped newlines is rendered as a single continuous block, resolving the reported parsing issue.
Highlights
- Regex modifications for escaped characters: The core change involves updating several regular expressions (
_blockLabel,blockSkip,_inlineLabel,del) insrc/rules.ts. Previously, these regexes primarily handled\.(escaped dot) or\\(escaped backslash). The update changes this to\[^], which allows\followed by any character, including\nfor a newline. This ensures that escaped newlines within Markdown elements, particularly link text, are correctly interpreted as part of the content rather than a line break. - Addition of new test cases: New test files,
test/specs/new/escape_newline.mdandtest/specs/new/escape_newline.html, have been added. These tests specifically demonstrate and validate the parsing and rendering of Markdown links where the link text contains an escaped newline character. This confirms that the fix correctly addresses the reported issue.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request aims to allow escaped newlines in link text, which is a good improvement. However, the implementation introduces syntactically invalid regular expressions by using \[^]. This will cause runtime errors. I've suggested replacing it with \[\s\S] which correctly matches any escaped character, including newlines, and resolves the syntax error. The accompanying test files are well-written and cover the intended new behavior.
## [16.2.1](v16.2.0...v16.2.1) (2025-08-27) ### Bug Fixes * allow escaped newline in link text ([#3752](#3752)) ([30c6630](30c6630))
|
Awesome! |
Marked version: 16.2.0
Description
Contributor
Committer
In most cases, this should be a different person than the contributor.