Skip to content

okhttp-digest coordinates have changed #1298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rjrudin opened this issue May 25, 2021 · 5 comments
Closed

okhttp-digest coordinates have changed #1298

rjrudin opened this issue May 25, 2021 · 5 comments

Comments

@rjrudin
Copy link
Contributor

rjrudin commented May 25, 2021

This is really just a note - see https://github.com/rburgst/okhttp-digest - the coordinates of okhttp-digest have changed with its move from jcenter to mavenCentral.

The scope of this ticket could also be larger - i.e. remove "jcenter()" from java-client-api and update any needed dependencies (such as okhttp-digest) and verify that the code still compiles, tests still work, and artifacts can still be assembled.

@rjrudin
Copy link
Contributor Author

rjrudin commented May 25, 2021

Note that this is an issue for me right now as I try to upgrade ml-javaclient-util to Java Client 5.4.0 and not use "jcenter()" as a repository. If I try to run a test using ml-javaclient-util, I get an error since okhttp-digest cannot be resolved, as its coordinates have changed.

So in order for ml-javaclient-util to stop using jcenter(), I have to modify its build.gradle script to bring in the updated version of okhttp-digest.

@rjrudin
Copy link
Contributor Author

rjrudin commented May 25, 2021

Here's what I'm doing to workaround the problem:

  api ('com.marklogic:marklogic-client-api:5.4.0') {
		exclude module: "okhttp-digest"
	}
	implementation 'io.github.rburgst:okhttp-digest:2.5'

@ehennum
Copy link
Contributor

ehennum commented Jun 1, 2021

Related to: #1230

Assuming (if and only if) the latest of all dependencies of the Java API are available on Maven Central, the build.gradle files for the Java API should just remove JCenter as a repository.

llinggit pushed a commit to llinggit/java-client-api that referenced this issue Jul 2, 2021
llinggit pushed a commit that referenced this issue Jul 2, 2021
@llinggit llinggit removed their assignment Jul 6, 2021
@llinggit llinggit added test and removed new labels Jul 6, 2021
llinggit added a commit that referenced this issue Jul 6, 2021
llinggit added a commit that referenced this issue Jul 6, 2021
llinggit added a commit to llinggit/java-client-api that referenced this issue Jul 6, 2021
llinggit added a commit to llinggit/java-client-api that referenced this issue Jul 6, 2021
llinggit added a commit to llinggit/java-client-api that referenced this issue Jul 6, 2021
llinggit added a commit that referenced this issue Jul 6, 2021
Previous change had line ending issue on windows
llinggit added a commit that referenced this issue Jul 6, 2021
Previous change has line ending issue on windows
llinggit added a commit that referenced this issue Jul 6, 2021
Previous change has line ending issue on Windows
@georgeajit
Copy link

Was able to run tests (Dev. team's JUnit tests) successfully and make zip file distribution. The zip file contains okhttp-digest version 2.5 jar file.

@georgeajit georgeajit added ship and removed test labels Jul 6, 2021
@llinggit
Copy link
Contributor

There's no server-side change in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants