Add unit tests for #1314, #1315, #1316. Also modify makeMap to work w… #1320

llinggit · 2021-10-05T06:22:08Z

…ith XsIntVal for fromSparql options.

So we can incorporate your pull request, please share the following:

What issue are you addressing with this pull request? - Implement op:bucket-group in Java API #1314, Expose op:sample-by function in Java Client API #1315, Expose the 3rd parameter of op.fromSPARQL #1316
Are you modifying the correct branch? (See CONTRIBUTING.md) - develop
Have you run unit tests? (See CONTRIBUTING.md) - Yes
Version of MarkLogic Java Client API (see Readme.txt) - nightly
Version of MarkLogic Server (see admin gui on port 8001) - 10.0-8
Java version (java -version) - 1.8
OS and version - Mac
What Changed: What happened before this change? What happens without this change?

…so modify makeMap to work with XsIntVal for fromSparql options.

ehennum

One concern about the future flexibility of the implementation of limit.

marklogic-client-api/src/main/java/com/marklogic/client/impl/PlanBuilderSubImpl.java

Add unit tests for marklogic#1314, marklogic#1315, marklogic#1316. Al…

6466287

…so modify makeMap to work with XsIntVal for fromSparql options.

llinggit added this to the java-client-api-NEXT milestone Oct 5, 2021

llinggit requested a review from ehennum October 5, 2021 06:22

llinggit self-assigned this Oct 5, 2021

Modify unit test for marklogic#1316.

49c4baa

ehennum approved these changes Oct 5, 2021

View reviewed changes

marklogic-client-api/src/main/java/com/marklogic/client/impl/PlanBuilderSubImpl.java Show resolved Hide resolved

llinggit merged commit 12854c8 into marklogic:develop Oct 5, 2021

Provide feedback