MLE-21334/remove Security attribute from cookie #320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update the Chart version to 2.0.1 and MarkLogic Version to 11.3.1 * update Notice and README for Helm 2.0.1 Release * update in Notice File * update latest Notice file * update go version to 1.23.6 for security vulverabilities * update version for vulerabilities --------- Co-authored-by: Peng Zhou <[email protected]>
rwinieski
requested review from
vitalykorolev,
pengzhouml,
barkhachoithani and
sumanthravipati
vitalykorolev
approved these changes
May 7, 2025
pengzhouml
approved these changes
May 8, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR updates the HAProxy configuration to remove the “secure” attribute from cookie directives as part of the MLE-21334 task, and bumps version numbers accordingly.
- Removed the “secure” attribute from HAProxy cookie configurations in multiple sections of configmap-haproxy.yaml.
- Updated appVersion and chart version in Chart.yaml to reflect new release.
- Updated the image tag in README.md to match the new version.
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| charts/templates/configmap-haproxy.yaml | Removed “secure” from cookie definitions per security attribute removal requirement. |
| charts/Chart.yaml | Bumped appVersion and chart version to track the new release version. |
| README.md | Updated image tag in documentation to align with the new version. |
Files not reviewed (2)
- NOTICE.txt: Language not supported
- go.mod: Language not supported
Comments suppressed due to low confidence (3)
charts/templates/configmap-haproxy.yaml:115
- Ensure that the removal of the 'secure' attribute is intentional and that the system's security requirements are met when cookies are transmitted over non-secure channels.
cookie haproxy insert indirect httponly nocache maxidle 30m maxlife 4h
charts/Chart.yaml:11
- [nitpick] Confirm that the updated appVersion is consistent with the product release notes and changelog for clarity.
appVersion: "11.3.1"
README.md:138
- [nitpick] Verify that the updated image tag in the README accurately reflects the new version and is consistent with the Chart.yaml change.
| `image.tag` | Image tag for MarkLogic image | `11.3.1-ubi-rootless-2.1.2` |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.