Repository navigation
ci: lint v5 changes against the PR base branch - #698
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
markus-wa
added a commit
that referenced
this pull request
Oct 11, 2026
Brings in encrypted net-message support (#696, #697) and the v5 lint base fix (#698). Conflict resolution: - protos & generated .pb.go: take v5's (identical to master's), keep usercmd.proto in generate.sh - s2_commands.go: master's resolution from a2dd17a (msgCreatorForType + usercmd handling) - events.go: WarnType order matches master so values are identical on v5 and v6 - ci.yml: keep v5's base_rev for lint-changes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/lint-changes.shdefaults toorigin/masteras baseline. Now that master is v6, every PR againstv5gets linted against master, so reviewdog reports lots of pre-existing issues in untouched files and fails thegolangci-lintcheck (e.g. on #697).This sets
base_revto the PR's base branch (falling back tov5for pushes).🤖 Generated with Claude Code