[Demo] Migrate from fetch-mock to msw
#10844
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erwanMarmelab
commented
Jul 21, 2025
| const data = generateData(); | ||
| const restServer = JsonGraphqlServer({ data }); | ||
| const handler = restServer.getHandler(); | ||
| const handlerWithLogs = (url: string, opts: any) => |
There was a problem hiding this comment.
We don't need to keep it. If we don't pass quiet: true to worker.start, it will automatically displays us the right logs 👍
djhi
requested changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
fetch-mockbrings us back some vulnerabilities.Solution
Change it for MSW
To Do
Additional Checks
masterfor a bugfix or a documentation fix, ornextfor a feature[ ] The PR includes unit tests (if not possible, describe why)[ ] The PR includes one or several stories (if not possible, describe why)[ ] The documentation is up to date