Preserve HTML comments within html block#282
Merged
Merged
Conversation
yhatt
added a commit
that referenced
this pull request
Jan 23, 2022
Preserve HTML comments within html block
yhatt
added a commit
that referenced
this pull request
Dec 24, 2024
…tml-block" This reverts commit d9bc9c7.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marp Core HTML sanitizer has no longer stripped HTML comments written within HTML block. When allowed HTML by
htmlconstructor option, Marp Core will keep HTML comment(s) if wrapped by the HTML tag.This behavior is helpful for user-side script usage. By wrapping JS by HTML comment, users can prevent escaping special characters in the script into HTML entities (Reported in marp-team/marp#250).
For safety, we have not taken the approach of recognizing script context to switch whether escape or not. Users who want to use the raw inline script always must wrap the script in HTML comment.