field2property rework#199
Merged
sloria merged 5 commits intomarshmallow-code:devfrom Apr 11, 2018
Nobatek:dev_jl_field2property_rework
Merged
field2property rework#199sloria merged 5 commits intomarshmallow-code:devfrom Nobatek:dev_jl_field2property_rework
sloria merged 5 commits intomarshmallow-code:devfrom
Nobatek:dev_jl_field2property_rework
Conversation
Also rework field2choices for a consistent interface
sloria
approved these changes
Apr 10, 2018
Member
sloria
left a comment
sloria
left a comment
There was a problem hiding this comment.
I think this approach is a big improvement. +1 to moving OpenAPI 3 work forward, too. Nice!
lafrech
commented
Apr 10, 2018
| return attributes | ||
|
|
||
|
|
||
| def field2write_only(field, **kwargs): |
Member
Author
There was a problem hiding this comment.
If this was Python 3 only, I'd write
def field2write_only(field, *, openapi_major_version, **kwargs):
Member
Author
|
Great. Shall I merge this, then? |
Member
|
LGTM 🚢 🇮🇹 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reworks field2property a bit to provide more consistency to the field2attribute methods. This makes it easier to manage different OpenAPI versions.
It also adds the
x-nullable/nullableandwriteOnlyattributes depending on the version.It does not address the optional spec attribute issue discussed in #197 but it is a first step.
@sloria, @Bangertm Feedback welcome.