Support of DateTime and Date formats#937
Closed
expobrain wants to merge 1 commit into
Closed
Conversation
expobrain
changed the title
expobrain
marked this pull request as draft
September 2, 2024 22:05
lafrech
reviewed
Sep 6, 2024
lafrech
left a comment
lafrech
left a comment
Member
There was a problem hiding this comment.
Hi. Thanks for digging into this.
I didn't take to time to review thoroughly but here's a question already.
Any idea why it stopped working as expected in version 6.4?
| "example": "1676451277514.654", | ||
| "min": "0", | ||
| } | ||
| elif field.format is not None: |
Member
There was a problem hiding this comment.
At this point, field.format can't be None due to line 549, right?
|
Also, format and pattern should not ever by None, according to openapi spec they must be strings. Probably should be removed from the ret dict when they are None. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds full support for rendering Date and DateTime Marshmallow fields with each of their
formatvalues.This solve the issue of
DateandDateTimewith a non-default format being rendered withformat: nullinstead offormat: dateandformat: date-timerespectively.