Skip to content

Fix typing on dump[s] #1416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sloria merged 1 commit into from
Sep 21, 2019
Merged

Fix typing on dump[s] #1416

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions src/marshmallow/schema.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ def _serialize(
ret[key] = value
return ret

def dump(self, obj: typing.Union[_T, typing.Iterable[_T]], *, many: bool = None):
def dump(self, obj: typing.Any, *, many: bool = None):
"""Serialize an object to native Python data types according to this
Schema's fields.

Expand All @@ -541,7 +541,7 @@ def dump(self, obj: typing.Union[_T, typing.Iterable[_T]], *, many: bool = None)
"""
many = self.many if many is None else bool(many)
if many and is_iterable_but_not_string(obj):
obj = list(typing.cast(typing.Iterable[_T], obj))
obj = list(obj)

if self._has_processors(PRE_DUMP):
processed_obj = self._invoke_dump_processors(
Expand All @@ -559,13 +559,7 @@ def dump(self, obj: typing.Union[_T, typing.Iterable[_T]], *, many: bool = None)

return result

def dumps(
self,
obj: typing.Union[_T, typing.Iterable[_T]],
*args,
many: bool = None,
**kwargs
):
def dumps(self, obj: typing.Any, *args, many: bool = None, **kwargs):
"""Same as :meth:`dump`, except return a JSON-encoded string.

:param obj: The object to serialize.
Expand Down