Fix call to get_declared_fields: pass dict_cls #2153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pass dict_cls even if a defaut was added to get_declared_fields, for compatibility with classes overriding get_declared_fields with no default value.
|
Sorry for Hyrum's law 😁 thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2152.
Now that
dicts are ordered, there is no point using anOrderedDictto store fields, so while working on #1896, I simplified the logic to always use adict.This screws up classes overriding
get_declared_fieldsthat still expect a dict class to be passed (#2152).Step back and pass dict class again. (Keep default value in
get_declared_fieldsimplementation.)