Skip to content
This repository was archived by the owner on Jul 16, 2020. It is now read-only.

Make generateMultiple and allocateLocaleArray deterministic#105

Merged
martinlindhe merged 1 commit into
martinlindhe:masterfrom
Jellyfrog:patch-1
Feb 12, 2020
Merged

Make generateMultiple and allocateLocaleArray deterministic#105
martinlindhe merged 1 commit into
martinlindhe:masterfrom
Jellyfrog:patch-1

Conversation

@Jellyfrog

Copy link
Copy Markdown
Contributor

Currently it outputs files and folders in an nondeterministic way.
Just copies the sorting from generateFromPath()

Machine 1:

.
..
fr
ru.json
ru
uk.json
uk
zh-TW
de.json
de
fr.json
zh-TW.json
en

Machine 2:

.
..
ru
fr
de
uk.json
zh-TW
uk
ru.json
fr.json
en
de.json
zh-TW.json

@Jellyfrog Jellyfrog changed the title Make generateMultiple() deterministic Make generateMultiple and allocateLocaleArray deterministic Feb 3, 2020
@martinlindhe

Copy link
Copy Markdown
Owner

Nice! Could you please rebase this patch to master branch so we can merge it?

@Jellyfrog

Copy link
Copy Markdown
Contributor Author

Ping @martinlindhe done.

@martinlindhe martinlindhe merged commit 0e29f04 into martinlindhe:master Feb 12, 2020
@martinlindhe

Copy link
Copy Markdown
Owner

Thanks!

@martinlindhe

Copy link
Copy Markdown
Owner

@Jellyfrog this PR breaks existing behaviour, please see #108
Feel free to resolve. In the meantime we will revert this PR.

martinlindhe added a commit that referenced this pull request Feb 13, 2020
@kapalla

kapalla commented Feb 13, 2020

Copy link
Copy Markdown

I honestly don't understand the problem of #108

(new SplFileInfo($fileinfo))->getFilename() resolves now the symlink and returns lang instead of core and user when calling $fileinfo->getFilename() directly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants