This repository was archived by the owner on Jul 16, 2020. It is now read-only.
Fix lang generation caused by missleading test case#38
Merged
Conversation
added 9 commits
December 20, 2017 10:27
Owner
|
Hi again and thanks for following up :-) Is the composer.lock changes necessary? It seems they are breaking in travis on some supported php versions at the moment, and reverting these should make it pass again. |
Owner
|
Thank you very much for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a mistake in my previous pull request #37 . My missleading test has caused wrong generation.
This PR fix that problem and also update phpunit dependency to latest version because the phpunit used before has some deprecated function in php 7.2I've revert back to previous phpunit version but the lock file still require php ^7.0. Apparently it was because
"illuminate/support"require"doctrine/inflector": "~1.1"and composer gave"doctrine/inflector": "1.2.0"which is require php^7.0.