[FR]: Fallback to "favicon.ico" when an icon is not found

[guihkx]

Brief description of the feature request.

I'm not familiar with how RSS Guard fetches icons of feeds, but it seems to work great in general, i.e. all of my feeds have the proper icon for them. The only site I'm having an issue at the moment is Github.

For instance, when you add the following ATOM feed to RSS Guard:

https://github.com/martinrotter/rssguard/commits/master.atom

RSS Guard won't get an icon for that feed:

So I thought about this fallback solution:

1. RSS Guard extracts the domain from that URL: github.com
2. RSS Guard adds /favicon.icon at the end of that URL
3. RSS Guard will then make a request to: github.com/favicon.ico
4. If the request successfully returns an image, then RSS Guard uses that. Otherwise, it sets an empty icon.

Thoughts?

---

Version: 3.8.4 (built on Linux/x86_64)
Revision: -nowebengine
Build date: 1/22/21 8:19 PM
Qt: 5.15.2 (compiled against 5.15.2)

[martinrotter]

I see. RSS Guard uses quite ellaborate way of detecting icons

https://github.com/martinrotter/rssguard/blob/master/src/librssguard/network-web/networkfactory.cpp#L140

it tries to download icon directly if specified in the feed, otherwise fallbacks to http://www.google.com/s2/favicons service

i will test with the feed and try to improve

[guihkx]

Thanks for linking the code, the method seems very robust. One can wonder why Google is returning an empty icon for the GitHub domain, though...

[guihkx]

Small observation: Any reason to use http instead of https for that Google request?

[guihkx]

DuckDuckGo's favicon service seems to work just fine for GitHub:

https://external-content.duckduckgo.com/ip3/github.1485827954.workers.dev.ico

Perhaps it could also be added as an option in RSS Guard.

[martinrotter]

Small observation: Any reason to use http instead of https for that Google request?

No specific reason, probably just overlooked it. I will replace it with duckduckgo as pretty much hate google for their policies.

[martinrotter]

Fixed, please test with newest dev. build when they become available.