[FR]: Replace AdBlock with uBlock Origin.

[WhyIsEvery4thYearAlwaysBad]

Brief description of the feature request.

AdBlock is slower and inefficient compared to uBO (or even AdBlock Plus) and can cause some issues (such as triggering BlockAdBlock) when trying to get RSS updates, due to injecting all filters by default.^{[1][2][3][4][5][6]} I have verified that there are no copyright issues with incorporating uBO's source code into other programs.^[1][2]

[martinrotter]

@WhyIsEvery4thYearAlwaysBad

uBlock origin (and pretty much every other adblock implementation) uses JavaScript as its primary runtime (V8) and is pretty much impossible to integrate withing RSS Guard. RSS Guard uses pretty much the same implementation as for example Falkon.

can cause some issues (such as triggering BlockAdBlock) when trying to get RSS updates

Does this happen to you? It should not, because adblocking in RSS Guard is NEVER used when downloading feeds/messages. It is literally used only when browsing web pages with internal web browser.

there are no copyright issues with incorporating uBO's source code into other programs

Legally, it is okay. Technically, pretty hardcore. You are welcomed to create nicely structured PR.

[martinrotter]

What about allowing user to somehow call 3rd-party user JavaScript code (nodejs) from RSS Guard? If allowed, you could probably use this.

[martinrotter]

For me:

• Replace C++ implementation of Adblock with modern nodejs-based implementation.
• Remove redundant C++ adblocking classes.
• Check if/how element hiding rules works.
• Tweak adblocking GUI dialog and add "Test" button to check if needed node modules are installed. Also add button with link to separate wiki article with adblock.

[martinrotter]

@WhyIsEvery4thYearAlwaysBad The solution proposed in my above replies is good, I started implementing it for RSS Guard 4.0.0. Change will be very nice and quite a lot of code could be now removed from RSS Guard as well, while keeping basically almost all previous features and gaining robust, stable and faster implementation.

[martinrotter]

Update docs, will start implementing soon.

https://github.com/martinrotter/rssguard/blob/version-4/resources/docs/Documentation.md#adblock

[WhyIsEvery4thYearAlwaysBad]

The node.js implementation should work fine. What should be included in adblock/uBO though?

[martinrotter]

What do you mean with:

What should be included in adblock/uBO though

?

[WhyIsEvery4thYearAlwaysBad]

What do you mean with:

What should be included in adblock/uBO though

I was just saying what features should be included.