[FR]: `SameId` for article filters

[sakkamade]

Brief description of the feature request

At last laying my hands on scraping and filtering features (truly amazing thing, btw), I found that a crucial for me element is likely missing.

It is also not documented here, so I suspect that it does not exist yet.

[sakkamade]

Well, I guess in my case I can adapt it to the SameTitle as well.
But please do tell me if it's okay.

[martinrotter]

not exist yet, can be safely added

Well, I guess in my case I can adapt it to the SameTitle as well.
But please do tell me if it's okay.

Sure, you can do that, I will add sameid to. But your probably do not want SameId, you want SameCustomId.

id is rssguard's internal ID of the message while customid is ID of the message as was provided by the feed/service.

https://github.com/martinrotter/rssguard/blob/master/resources/docs/Documentation.md#messageobject-class

?

[sakkamade]

while customid is ID of the message as was provided by the feed/service.

Yes, this one.

[martinrotter]

b35c977

[sakkamade]

Thank you very much!

[sakkamade]

@martinrotter Does not seem to work?

[martinrotter]

Will double check.

[martinrotter]

I checked and made some changes and should work, sample log from app:

time="    10.167" type="debug" -> Message custom ID: https://www.cnn.com/2021/07/11/us/eliot-middleton-mechanic-fix-donates-cars-bbq-trnd/index.html
time="    10.168" type="debug" -> message-model: Prepared query for MSG duplicate identification is: 'SELECT COUNT(*) FROM Messages WHERE custom_id = :custom_id AND account_id = :account_id AND feed = :feed;'.
time="    10.168" type="debug" -> database: Executed SQL for message duplicates check: 'SELECT COUNT(*) FROM Messages WHERE custom_id = 'https://www.cnn.com/2021/07/11/us/eliot-middleton-mechanic-fix-donates-cars-bbq-trnd/index.html' AND account_id = 1 AND feed = '2';'.

Sample filter:

function filterMessage() {
  console.log("Message custom ID: " + msg.customId);
  var isDupl = msg.isDuplicate(MessageObject.SameCustomId);
  return isDupl ? MessageObject.Ignore : MessageObject.Accept;
}

[sakkamade]

Although my script does not look as neat, it does work with SameTitle, but not with the SameCustomId:

const conditions = [
  	'title1',
  	'title2'
	];
function filterMessage() {
  if (msg.isDuplicateWithAttribute(MessageObject.SameCustomId)) {
    return MessageObject.Ignore;
  } 
  else if (conditions.some(el => msg.title.includes(el)) >= 1) {
    return MessageObject.Accept;
  } 
  else {
    return MessageObject.Ignore;
  }
}

Thoughts?